chore: explicitly install Corepack in CI#452
Closed
wojtekmaj wants to merge 1 commit intonpmx-dev:mainfrom
Closed
Conversation
Following Node.js decision not to include Corepack in future versions of Node.js, to prevent any surprises and benefit from potential fixes in Corepack, I suggest we install the latest version of Corepack explicitly on CI instead of just hoping it's there.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates CI workflows to explicitly install Corepack via npm, anticipating future Node.js versions that no longer bundle Corepack by default and aiming to keep package manager tooling stable on CI.
Changes:
- Replace direct
corepack enablecalls with an explicitInstall Corepackstep in the main CI workflow. - Apply the same explicit Corepack installation pattern to the Lunaria workflow.
- Apply the same explicit Corepack installation pattern to the autofix workflow.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| .github/workflows/lunaria.yml | Adds a named step to install Corepack before setting up Node and running pnpm for the Lunaria overview job. |
| .github/workflows/ci.yml | Adds named steps to install Corepack before Node setup in all CI jobs (lint, test, browser, a11y, knip) that rely on pnpm. |
| .github/workflows/autofix.yml | Adds a named step to install Corepack before Node setup in the autofix workflow, which also uses pnpm. |
wojtekmaj
changed the title
wojtekmaj
changed the title
Member
|
merging #455, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This PR has an alternative: #455
Following Node.js decision not to include Corepack in future versions of Node.js, to prevent any surprises and benefit from potential fixes in Corepack, I suggest we install the latest version of Corepack explicitly on CI instead of just hoping it's there.